Przeglądaj źródła

♻️ refactor(auth): replace magic numbers with enum constants

- 使用DisabledStatus.DISABLED替代1表示用户禁用状态
- 使用DeleteStatus.DELETED替代1表示用户删除状态
- 在auth.middleware.ts和auth.service.ts中统一状态检查方式
- 提高代码可读性和可维护性,避免硬编码值带来的潜在问题
yourname 6 miesięcy temu
rodzic
commit
39f28bcab1

+ 3 - 2
src/server/middleware/auth.middleware.ts

@@ -3,6 +3,7 @@ import { AuthService } from '../modules/auth/auth.service';
 import { UserService } from '../modules/users/user.service';
 import { AppDataSource } from '../data-source';
 import { AuthContext } from '../types/context';
+import { DisabledStatus, DeleteStatus } from '@/share/types';
 
 export async function authMiddleware(c: Context<AuthContext>, next: Next) {
   try {
@@ -27,11 +28,11 @@ export async function authMiddleware(c: Context<AuthContext>, next: Next) {
     }
 
     // 检查用户状态
-    if (user.isDisabled === 1) {
+    if (user.isDisabled === DisabledStatus.DISABLED) {
       return c.json({ message: 'User is disabled' }, 403);
     }
 
-    if (user.isDeleted === 1) {
+    if (user.isDeleted === DeleteStatus.DELETED) {
       return c.json({ message: 'User not found' }, 401);
     }
 

+ 3 - 3
src/server/modules/auth/auth.service.ts

@@ -1,7 +1,7 @@
 import jwt from 'jsonwebtoken';
 import { UserService } from '../users/user.service';
 import { UserEntity as User } from '../users/user.entity';
-import { DisabledStatus } from '@/share/types';
+import { DisabledStatus, DeleteStatus } from '@/share/types';
 import debug from 'debug';
 
 const logger = {
@@ -54,11 +54,11 @@ export class AuthService {
       }
 
       // 检查用户状态
-      if (user.isDisabled === 1) {
+      if (user.isDisabled === DisabledStatus.DISABLED) {
         throw new Error('User is disabled');
       }
 
-      if (user.isDeleted === 1) {
+      if (user.isDeleted === DeleteStatus.DELETED) {
         throw new Error('User not found');
       }